Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie banner rendered in cached pages #36

Open
callmewind opened this issue Jun 27, 2017 · 0 comments
Open

Cookie banner rendered in cached pages #36

callmewind opened this issue Jun 27, 2017 · 0 comments

Comments

@callmewind
Copy link

Hello,
Thanks for this little app!

I just noticed that the rendering of the banner is evaluated on the template tag. The problem is that in cached pages it can be rendered or not depending on the user who loaded the page when it was not in cache and other users will get the banner or not depending on that and not on the cookie set.
This could be solved rendering always the banner as hidden, and then showing it only if we can't detect the cookie with javascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant