Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPing failures when running during docker container build #706

Open
sashkab opened this issue Mar 16, 2024 · 0 comments
Open

TestPing failures when running during docker container build #706

sashkab opened this issue Mar 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sashkab
Copy link

sashkab commented Mar 16, 2024

Describe the bug

After upgrading to gatus 5.8.0, TestPing fails when run while building Dockerfile. This seems to be relates to the code in lines 95-99 of client_test.go

What do you see?

#9 58.95 ok  	github.com/TwiN/gatus/v5/alerting/provider/twilio	1.016s
#9 60.44 ok  	github.com/TwiN/gatus/v5/api	1.438s
#9 60.44 --- FAIL: TestPing (0.55s)
#9 60.44     client_test.go:95: expected true
#9 60.44     client_test.go:97: Round-trip time returned on failure should've been 0
#9 60.44 FAIL
#9 60.44 FAIL	github.com/TwiN/gatus/v5/client	1.350s

What do you expect to see?

Expected to test to pass.

List the steps that must be taken to reproduce this issue

Modify Dockerfile to enable tests and run docker build . --file Dockerfile.

Version

5.8.0

Additional information

Seems to be related to #661, when attempting to ping ::1 on container which supports only ipv4...

@sashkab sashkab added the bug Something isn't working label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant