Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msPKI-Certificate-Name-Flag check in ESC1-3 could result in false negatives #122

Open
TrimarcJake opened this issue Mar 3, 2024 · 0 comments
Open

msPKI-Certificate-Name-Flag check in ESC1-3 could result in false negatives #122

TrimarcJake opened this issue Mar 3, 2024 · 0 comments
Assignees
@TrimarcJake
Labels
bug Something isn't working

Comments

@TrimarcJake
Copy link
Owner

msPKI-Certificate-Name-Flag check in ESC1-3 currently uses a direct comparison (-eq) instead of a bitwise comparison (-band) which could result in false negatives in situations where multiple msPKI-Certificate-Name-Flag bits are enabled.
@TrimarcJake TrimarcJake added the bug Something isn't working label Mar 3, 2024
@TrimarcJake TrimarcJake self-assigned this Mar 3, 2024
TrimarcJake added a commit that referenced this issue Mar 9, 2024
@TrimarcJake
Resolves #122
4c0274f
@TrimarcJake TrimarcJake mentioned this issue Mar 9, 2024
Merged
TrimarcJake added a commit that referenced this issue Apr 18, 2024
@TrimarcJake
Merge pull request #128 from TrimarcJake/122-improve-esc1-3
f34c0e1 
Resolve #122: "msPKI-Certificate-Name-Flag check in ESC1-3 could result in false negatives"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrimarcJake TrimarcJake

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TrimarcJake