-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparency does not work as expected in gif creation #3
Comments
weird, do you think it's something to do in this line? |
I suspect so. As best as I can tell, it looks like this stems from the different frames having different palettes which don't line up (i.e. transparent in frame 0 might be the palette index of blue in frame 3). The second (single color) example above seems to corroborate the idea of palette indexes getting swapped around. I spent an hour or so this morning reading through I'm sorry I can't be of more help, I'll continue looking around and seeing what I can find. |
If anyone needs a quick workaround: the individual layer files are no longer deleted after run, so you can just package them up into a gif manually using your favorite gif-capable image editor (e.g. gimp, etc.) |
Looks like this is no longer possible as the library cleans up after itself now. |
Any update on this? I'm noticing it only happening when |
@ethanopp Haven't quite gotten the time to investigate this further, unfortunately. But as ojensen said, it does seem to be an issue with the If you're interested in investigating this - I'd say that an easy fix may involve checking if RGBA is being used for the final save, if it's not being used, it should start being used unless it causes issues for other usecases. If there's no fix possible on the |
Ended up using this and it seems to be working: |
Not sure if things are different now than before since I just started using this. But it appears that even when I save each individual layer it appears that each have also lost their transparency. I've tried some of the methods in the above comment to no avail. What I do notice it seems that this happens in particular only to larger resolution files. EDIT: Nevermind??? I think I'm trippin' balls here. I'm running the solution from https://gist.github.com/egocarib/ea022799cca8a102d14c54a22c45efe0 and it works just fine??? It's suddenly working. What's nice about this one is |
Thank you for this excessively fun implementation! While playing around with it, I noticed that transparency doesn't seem to work quite right in GIF mode.
When glitching a reasonably complex image with a transparent background, the background appears to turn black:
Interestingly, when glitching a single-color image with a transparent background, I get a black background again but the blue rectangle has become transparent:
As such, I suspect this results from not keeping a constant palette when operating over the individual frames. Note that this seems to occur during the final combination and saving of the frames, as the individual frame files written to the
Glitched GIF
directory all appear to be correct.The text was updated successfully, but these errors were encountered: