Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use incremental number in URLs of radio lists #67

Open
TomaszGasior opened this issue Jan 6, 2020 · 0 comments
Open

Don't use incremental number in URLs of radio lists #67

TomaszGasior opened this issue Jan 6, 2020 · 0 comments
Labels
bug Something isn't working help wanted Help from outside is needed

Comments

@TomaszGasior
Copy link
Owner

Currently it's very easy to guess URLs of unlisted radio tables which makes this feature useless. :-(

Plan:

  • Introduce randomly generated unique identifier (not related to numeric incremental ID) for each radio table and persist it alongside other information in database.
  • Don't use original incremental ID in URLs of unlisted radio tables — throw 404 error exception.
  • MAYBE don't use original ID at all, for all radio tables — for simpler maintenance and consistency. In this case it's needed to create backwards compatible redirection from old style URL for public radio tables.

Changing URLs of unlisted radiotables must be non backwards compatible (without redirection from old URL) but this may make current users of this feature unhappy. It's needed to talk with users about the problem. Currently there are 163 radio tables in RadioLista and 9 of them have set visibility to unlisted.

@TomaszGasior TomaszGasior added the bug Something isn't working label Jan 6, 2020
@TomaszGasior TomaszGasior added this to the 3. Make it better milestone Feb 2, 2020
@TomaszGasior TomaszGasior self-assigned this Feb 2, 2020
@TomaszGasior TomaszGasior removed their assignment May 15, 2020
@TomaszGasior TomaszGasior changed the title Don't use incremental number in URLs of radio tables Don't use incremental number in URLs of radio lists May 17, 2020
@TomaszGasior TomaszGasior removed this from the 3. Make it better milestone May 26, 2020
@TomaszGasior TomaszGasior added the help wanted Help from outside is needed label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Help from outside is needed
Projects
None yet
Development

No branches or pull requests

1 participant