Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] color wheel based on picked color #60

Open
farfromrefug opened this issue Feb 20, 2020 · 9 comments
Open

[FR] color wheel based on picked color #60

farfromrefug opened this issue Feb 20, 2020 · 9 comments

Comments

@farfromrefug
Copy link

Screen Shot 2020-02-20 at 17 05 40

When picking a color the wheel update to propose you colors related to the picked color.

I use that feature all the time. Would love to see that in your app.

@Toinane
Copy link
Owner

Toinane commented Feb 20, 2020

Hi @farfromrefug ! Thanks for your issue 🙂
If I understand, when you pick a color you have a colorwheel of colors that like the picked one. It is already available on Colorpicker no? When you open the tint menu, the first line is a colorwheel of colors that like the one you have on Colorpicker. If not can you precise it? What is the software you use on your screenshot? Thanks you! 😄

@farfromrefug
Copy link
Author

@Toinane first thanks for the really fast answer :D
Now yes it is similar to what you already do but it still seems different and is not what i expect.
Screen Shot 2020-02-20 at 20 57 14
I picked a color from the wheel. Now i expect to see similar colors in the sense that if i choose a pastel color the wheel (doesnt have to be a wheel :P ) give me different colors from the spectrum like you do but they should be at the same pastel level if i can say that.
I think it is all based on HSL. And i think this article is talking about what i do. I think the wheel is only:

  • compute the HSL from the selected value. Compute 11 others values by shifting 30degrees each time (360/12 -30).

Seeing your code it seems to be what you do but the colors you show bug me. For example after picking the orange from the wheel the greens you show seem really "bright/flashy"

@farfromrefug
Copy link
Author

Actually they might use a different formula.
using this
http://www.workwithcolor.com/hsl-color-schemer-01.htm?cp=3CFB59&ch=129-96-61&cm=0&sm=1&mil=0&dst=10
i seem to get the same as you

@Toinane
Copy link
Owner

Toinane commented Feb 20, 2020

Ahah thanks for the precision, yeah its like my colorwheel is a little bit buggy so! Okay I'll correct that for the next breaking update ! You can see #36 (yeah its now an old branch but I'll be more active now!)

@Toinane
Copy link
Owner

Toinane commented Feb 20, 2020

About curious, why you have [fr] in the title?

@Toinane Toinane self-assigned this Feb 20, 2020
@farfromrefug
Copy link
Author

fr is for feature request ;)

@Toinane
Copy link
Owner

Toinane commented Feb 20, 2020

Ohhh.. okay I was wondering if it was for french ahah! (Because French is my native language) I'll know for the next time thanks ahah

@farfromrefug
Copy link
Author

@Toinane French is my native language too, bon a savoir :)

@Toinane
Copy link
Owner

Toinane commented Feb 20, 2020

Ahah effectivement ! On s'embête pour rien alors ! Bon c'est toujours plus agréable pour les autres s'ils veulent comprendre ce qu'on raconte !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants