Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails while compiling #10

Open
097115 opened this issue May 12, 2020 · 12 comments
Open

Fails while compiling #10

097115 opened this issue May 12, 2020 · 12 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@097115
Copy link

097115 commented May 12, 2020

macOS 10.11:

gcc -c -g -O3 -fPIC -Wall -Wsign-compare -Iparser -Iblender -Iinclude -I/usr/include/libxml2   -c -o src/mandown.o src/mandown.c
gcc -c -g -O3 -fPIC -Wall -Wsign-compare -Iparser -Iblender -Iinclude -I/usr/include/libxml2   -c -o src/view.o src/view.c
src/view.c:104:19: error: use of undeclared identifier
      'A_ITALIC'
        attr[1] = A_ITALIC;
                  ^
1 error generated.
make: *** [src/view.o] Error 1
@Titor8115
Copy link
Owner

Interesting, would you mind sharing your Ncurses version? I read somewhere that Homebrew has a new version of Ncursesw that links to the older Ncurses. I’ll do some search as well.

@097115
Copy link
Author

097115 commented May 12, 2020

Interesting, would you mind sharing your Ncurses version?

Was 6.1, upgraded with Homebrew to 6.2 (via downloading this file), same error :)

@Titor8115
Copy link
Owner

Interesting, would you mind sharing your Ncurses version?

Was 6.1, upgraded with Homebrew to 6.2 (via downloading this file), same error :)

@Titor8115 Titor8115 reopened this May 12, 2020
@Titor8115
Copy link
Owner

Interesting, would you mind sharing your Ncurses version?

Was 6.1, upgraded with Homebrew to 6.2 (via downloading this file), same error :)

That is strange... I did find A_ITALIC macro in the tar file you uploaded. Would you mind try one more thing by changing A_ITALIC to A_NORMAL and see if it would compile.

@Titor8115 Titor8115 added bug Something isn't working help wanted Extra attention is needed labels May 12, 2020
@097115
Copy link
Author

097115 commented May 12, 2020

Yeah, it compiles[1] but doesn't display italics as a consequence :)

--
[1]: I also had to change Makefile:30 from this:

LDFLAGS=-g -O3 -Wl,--copy-dt-needed-entries -lncursesw -lxml2 -Wall -Werror

to this:

LDFLAGS=-g -O3 -Wl,-lncurses -lxml2 -Wall -Werror

@Titor8115
Copy link
Owner

I’ll see what can be done.

The Makefile is under makeover. I didn’t expect the sudden increase in community and system at the beginning.

@097115
Copy link
Author

097115 commented May 12, 2020

No problem :)

@lucamot
Copy link

lucamot commented May 15, 2020

On macOS, as a temporary fix, you could replace A_ITALIC with NCURSES_BITS(1U,23), which is the original definition in ncurses.h. Also, remove --copy-dt-needed-entries from LDFLAGS as already stated above.

@097115
Copy link
Author

097115 commented May 16, 2020

you could replace A_ITALIC with NCURSES_BITS(1U,23)

@lucamot, the resulting file, compiled with these changes still doesn't display italics for me, though.

@Titor8115
Copy link
Owner

@097115 I uploaded a new Makefile and view.h to fix the compile issue and A_ITALIC issue. It just hit my mind that the terminal emulator might be the reason ITALIC isn't rendered. What emulator are you using?

@097115
Copy link
Author

097115 commented May 29, 2020

It just hit my mind that the terminal emulator might be the reason ITALIC isn't rendered

No :). I've tried iTerm and Alacritty, they both support italics.

(On this nw Makefile: it compiles now but italics indeed aren't rendered.)

@Titor8115
Copy link
Owner

Titor8115 commented May 29, 2020

No :). I've tried iTerm and Alacritty, they both support italics.

(On this nw Makefile: it compiles now but italics indeed aren't rendered.)

Alright, I'll test it out if it is an issue across Mac OS. And I'll try to implement ANSI for the italics.

And thanks for the feedback!!!!

@Titor8115 Titor8115 self-assigned this Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants