Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaflets map #26

Open
rhaamo opened this issue Feb 8, 2018 · 4 comments
Open

leaflets map #26

rhaamo opened this issue Feb 8, 2018 · 4 comments

Comments

@rhaamo
Copy link
Contributor

rhaamo commented Feb 8, 2018

hello,

I worked a long time ago on using Leaflets instead of Google Maps on my branch¹ and it works more-or-less good, except an issue where sometimes some markers are created without a lat/lon (which is something gmaps accepts, not leaflet) and some markers with lat/lon aren't created properly even with lat/lon. (yeah I'm stuck at this point and I cannot figure why this behaviour)

That's the current state and I haven't much used it a lot (I moved house in the mean time so I lost interest on it at this time).

Are you interested on continuing this migration ? There is some benefits on using leaflets and I may restart to look on how to improve that if there is interest.

¹ https://github.com/rhaamo/airSuck/tree/fixes

@ThreeSixes
Copy link
Owner

I'm down to keep this going if you are. I'm also getting ready for some big changes, but if you want to keep this going I'm in.

@rhaamo
Copy link
Contributor Author

rhaamo commented Aug 14, 2018

Sorry for not replying sooner.
Now with the whole gmaps api situation I think leaflets is the way to go.
I haven't touched my branch since a long time, and as stated in the first post it more-or-less works, with some issues.
This part is the one where I have the less knowledge and not familiar with, and actually I don't know if I will be able to fully resolve issues with my implementation.

@mjlurbanist
Copy link
Collaborator

mjlurbanist commented Aug 14, 2018 via email

@rhaamo
Copy link
Contributor Author

rhaamo commented Aug 14, 2018

I never used mapbox, only leaflets on other projects.
On the current implementation of leaflets in airSuck I also use Leaflets Providers to have various maps (Black and white, OSM, OpenTopo, Stamen Terrain or even Esri ocean basemap, with a togglable overlay of OpenSeaMap).
Leaflets Providers can also use mapbox maps but same, never used.
I will anyway re-setup airSuck one of thoses days because I can receive AIS where I live.
I will see if I can go further in debugging the current issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants