-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doubt about average calculation in SpecularMap #33
Comments
Hi, i've created an AppImage with some changes that fixes what i commented before and #11 |
Have you already committed the fix for the specular map? I can't see it in your fork. |
Oh, I think I forgot.. I'll do it when I reach home! |
Hi, |
I had to comment out the "include cv.hpp" to compile, it doesn't seem to be used. Leftover of a test? I also tried to test your appimage, but it doesn't work on my ancient Ubuntu 14.04 - however I guess this is expected, because it's a very old distro.
|
Hi, |
Hi,
I was looking at the code, and i saw that in specular map, the average calculation was like this:
But imho this is not an average, because if every channel has a multiplier of let say 0.1, then the sum is going to be 0.4, and you are going to divide the whole sum by 0.4. Shouldn't the division be the sum of each channel divided by the ammount of channels used?
I really don't know how specular maps are calculated, so it's just a question.. i can fix it if it is a bug.
The text was updated successfully, but these errors were encountered: