Testing Practice: Clarification on caeser cipher.

[dvs-codes]

Checks

• This is not a duplicate of an existing issue (please have a look through our open issues list to make sure)
• I have thoroughly read and understand The Odin Project Contributing Guide
• Would you like to work on this issue?

Describe your suggestion

In the caeser cipher function, it is not clear whether we have to test considering punctuations or not ? if yes then in which way ? for example, in alphabet and numbers we shift in order eg. for factor 2 'a' becomes 'c' but if we have do it for let's say the period ('.') which way does it go ?

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-testing-practice

(Optional) Discord Name

DVS-CODES

(Optional) Additional Comments

No response

[CouchofTomato]

Usually punctuation isn't changed. So the test would be that a . remains a .

We could clear up the wording to make that clear if you think that would be useful?

[dvs-codes]

yeah I think we should make it little clear, we should provide a clearcut example too so that it's understood properly ? eg. Ab,C.De ==> Bc,D.Ef (for factor 1, punctuations remain as it is.)

…

On Wed, 15 May, 2024, 2:50 pm Austin, ***@***.***> wrote: Usually punctuation isn't changed. So the test would be that a . remains a . We could clear up the wording to make that clear if you think that would be useful? — Reply to this email directly, view it on GitHub <#27968 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7TN4MKJVIREKOJOFF4UODDZCMSFBAVCNFSM6AAAAABHTJ7GR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGAYDKNJXGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[CouchofTomato]

Thanks. You haven't indicated you want to work on this issue so I'm opening it up for others.

[catbree]

Hello there, I'm currently on the lesson "Using Git in the Real World" and came across this issue while reading up on the contributing guide.

Can I be assigned this issue? It is my first time and I would love to work on this.

[CouchofTomato]

@catbree Sure. Thanks for taking this on. It's all yours.