Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless features #104

Open
2 tasks
TheElectronWill opened this issue Jan 18, 2022 · 0 comments
Open
2 tasks

Remove useless features #104

TheElectronWill opened this issue Jan 18, 2022 · 0 comments

Comments

@TheElectronWill
Copy link
Owner

TheElectronWill commented Jan 18, 2022

  • valueMap():

After a search of all the Github projects mentioning night-config, I've found that the only occurrences of config.valueMap() are for iterating on the config entries, keys or values. There are much simpler ways of providing iterations on entries, keys or values, therefore I could ditch valueMap. Since on-the-go conversion seems to be unused too, its dependencies like TransformingMap can be removed to make the library lighter.

  • TransformingMap and ConversionTable:

At the very least they should be moved to another module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant