Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: The search bar does not work properly #252

Open
BamaCharanChhandogi opened this issue Aug 5, 2023 · 3 comments · May be fixed by #281
Open

Bug: The search bar does not work properly #252

BamaCharanChhandogi opened this issue Aug 5, 2023 · 3 comments · May be fixed by #281
Labels
bug Something isn't working

Comments

@BamaCharanChhandogi
Copy link
Member

BamaCharanChhandogi commented Aug 5, 2023

Description of the bug

Description of the bug
When I click the back button search result shows repeated in below.

How to reproduce
Write anything on the search bar and click the back button, You will notice.

Add screenshots of the bug (if applicable)

video.mp4

Additional information/context

No response

@BamaCharanChhandogi BamaCharanChhandogi added the bug Something isn't working label Aug 5, 2023
@anshvert
Copy link

anshvert commented Oct 1, 2023

Ok Understood the issue. Could you explain how the expected solution should work?

  • You want to redirect to the home page?
  • stay at search page and clear search bar input?
  • or anything else ?

@Panquesito7
Copy link
Member

Ok Understood the issue. Could you explain how the expected solution should work?

  • You want to redirect to the home page?
  • stay at search page and clear search bar input?
  • or anything else ?

Great catch, thank you! 🚀
I believe it should go back to the last page before the search page was accessed.

@ahmed0saber
Copy link
Contributor

I think the issue is not clear enough, as many people have misunderstood it.
The issue should be named "Prevent search parameters from being pushed to browsing history", with description explaining that pressing the browser back button should take us to the previous page, instead of the previous search result..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants