New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to write a good pull request / do good code review #214

Open

yiwen-h opened this issue Nov 6, 2024 · 1 comment

Labels

C&C ☕

Member

yiwen-h commented Nov 6, 2024

What are best practices
What are some bad things to do?
We could look at Jack’s approach, for example (Matt)

yiwen-h added the C&C ☕ label

github-project-automation bot added this to Coffee and Coding ☕🧑‍💻

github-project-automation bot moved this to Potential in Coffee and Coding ☕🧑‍💻

Contributor

matt-dray commented Nov 14, 2024

Refer to @craig-parylo's excellent PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment