Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost taps in video player UI #3

Open
theScrabi opened this issue Oct 25, 2024 · 2 comments
Open

Ghost taps in video player UI #3

theScrabi opened this issue Oct 25, 2024 · 2 comments
Labels
bug Issue/PR is related to a bug UI/UX Issue is related to UI/UX

Comments

@theScrabi
Copy link
Member

theScrabi commented Oct 25, 2024

When an animation is going on, apparently compose only transforms or alters the pixels of the drawn elements. It does not change the hit boxes. Therefore, you can tap on elements that are visually not there anymore or are visually at a different location.

You can find this at different places but here is an example to reproduce:

  1. Play a video and go to fullscreen mode
  2. Open the chapters screen
  3. Close the chapter screen
  4. Immediately after closing tap somewhere in the middle of the screen. (The hiding animation of the chapters select screen must still go on).

What happens:

To the eye it looks like the chapter select screen is not visible anymore. However, by quickly taping in the middle of the screen while the chapter select screen hiding animation is still going on you were still able to select a different chapter.

What should happen:

The mentioned behavior is irritating. Since NewPipe is WISWIG.
You can not see the select screen. Instead, you can see either the blank video or the video controller UI.
Because of this either the video controller or the touch ui should get the input. Not the hiding chapter UI.

Keep in mind that this issue is just an example. You can find a similar behavior when the video controller UI hides or when the playlist select screen hides.

@theScrabi theScrabi added the bug Issue/PR is related to a bug label Oct 25, 2024
@theScrabi
Copy link
Member Author

I temporarily fixed this issue but disabling the animations here and here.

@theScrabi
Copy link
Member Author

@ShareASmile ShareASmile added the UI/UX Issue is related to UI/UX label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR is related to a bug UI/UX Issue is related to UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants