Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects to keep track of similar issues #2937

Closed
Stypox opened this issue Jan 8, 2020 · 10 comments
Closed

Projects to keep track of similar issues #2937

Stypox opened this issue Jan 8, 2020 · 10 comments
Assignees
@Stypox
Labels
meta Related to the project but not strictly to code

Comments

@Stypox
Copy link
Member

Stypox commented Jan 8, 2020 •
edited
Loading

Some time ago (~two months) I finished labelling every issue in the NewPipe repo. Through the journey of reading every issue I collected a list of the common/important ones. Currently I have it in simple raw text, but I thought I could create a GitHub Project for every category. This would make it easier both for us and for new contributors to know which issues are important and supported by the team (*) and start working on one. Also, since many issues are really similar (i.e. both feature requests aim to solve the same need // both problems arise from the same bug) but not identical (so they cannot be considered duplicates), it would help to compare proposed solutions and find the one solving the most problems.

(*) I collected the issues that I thought as being compatible with the vision of NewPipe and that I considered having a great usefulness/effort ratio or priority/effort ratio. But since this is heavily biased on my opinion, feel free to add/suggest anything :-). Also, I could have skipped or forgotten to add some important issue, but I don't think this is a big deal since Projects are editable.

Here are the issues I collected (I didn't put any time in formatting this, since it will be far more accessible once in Projects):

Issues

Long-press menu: #437 #2198 #2354 #2368 #2383 #1907 #2510 #2583
Share menu: #1170 #1487

Yt problems: #2509 #2525 #2673 #2415 #2600 #2647 #2674 #2680 #2683 #2750 #2754 #2765 #2766
Replace drawables/resources #1199 #1603
Auto-play video when opened #1200
Link support: #598 #621 #868 #928 #2425 #1556 #2132 #2266 #2313 #2351 #2526 #621 (comment)
More settings #735 #981 #1113 #1329 #1489 #1536 #1761 #1780 #1795 #1823 #2392 #2613 #2811
Description links: #1025 #2526
Language: #578 #1013 #1130 #1132 #1215 #1588 #2848
Exporting database: #1163 #1281 #1493 #1788
Missing SoundCloud trending?? #1228
Channel page: #2414 #1066 (missing videos) #1269
Main page tabs: #2477 #2565 #2088 #1647 #2438 #2678
Playlist #1473 #1188 #1956
Premiered videos not working: #1517
Introduction/tours #859 #1814

Popup: #1159 OREO-pip #2223 #2455 to-info #1832 #1032 embedded #1200
Background player: #1221 #1265 #1967 #1780 #1660
Main video player: #1064 #1317 #1600 #1634
Douple tap forward seek changeable #1401
Auto-select quality: #518
Refresh expired link: #938 #1265
Shuffle only first n: #875
Android TV: #1363
Play when already backgrounded continues in fullscreen: #1366
Long press enqueue paused #2611
Request audio focus on/off: #2681

Collections: #1317 #1387 #1448 #1603 #1717 #1872 #1922 #2610 #2743
More info to crash reports: #1816

Channel crashes if only one item (e.g. avatar ) could not be loaded #2228

@TeamNewPipe/appdev @karyogamy @kapodamy @PeterHindes @jimbo1qaz @timfbfbfbfb

Related: #2523
@Stypox Stypox added the meta Related to the project but not strictly to code label Jan 8, 2020
@Stypox Stypox self-assigned this Jan 8, 2020
@B0pol
Copy link
Member

B0pol commented Jan 8, 2020 •
edited
Loading

That's really nice.
Maybe you should pin this issue ?

feel free to add/suggest anything

IMO #2590 deserved to be quoted here (it's comment replies issue)

@TobiGr
Copy link
Contributor

TobiGr commented Jan 9, 2020

Thank you for the effort! That's a massive list :O
I agree that creating projects for large issue groups is useful (e.g. link support, settings, ...). But we have issue labels which help us to group certain things, too (e.g. we have the youtube label). How should we proceed with them?
Please be aware that we should not open 15< projects because that would make it messy again.

@Stypox
Copy link
Member Author

Stypox commented Jan 10, 2020 •
edited
Loading

IMO #2590 deserved to be quoted here

@B0pol I added it below, thanks ;-)

we should not open 15< projects

@TobiGr I grouped the issues in 8 categories, so 8 projects should be ok. One of the last entries of the above list is Collections, i.e. issues that group a broad set of issues and propose a common solution. Since those are not "issues to be solved" but more some kind of "guidelines", I think we should open and pin an issue containing the list of collections.
Here are the 9 categories:


But we have issue labels which help us to group certain things, too (e.g. we have the youtube label). How should we proceed with them?

The projects I will be creating contain only important issues, while labels cover every issue (e.g. a bug observed by only one user would be labelled, but not inserted in any project)

@cool-student
Copy link
Contributor

@Stypox I would put all the Notification bugs into one project. I'm talking about these here:
#1660 #2943 #2845 #1104 #1207 #2233 .
most of these are about adding the colored notification that can be added starting with Android Lollipop and up and then some about the new Android 10 Seekbar in the media notifications with the others being minor bugs that are most likely caused by us not using a media style notification, then there's the last bug which is about improving the download notifications.
I would also like to work on that. I'm going to use #1660 as the main issue for the colored notifications since it seems to have the most useful information.

@TobiGr
Copy link
Contributor

TobiGr commented Jan 13, 2020 •
edited
Loading

@Stypox's categories plus a notification category look good to me 👍

The projects I will be creating contain only important issues, while labels cover every issue (e.g. a bug observed by only one user would be labelled, but not inserted in any project)

@Stypox sounds good.

Btw. I try to open milestones for further releases to help us focusing on a small number of PRs to be reviewed to speed up release cycles.

@Stypox
Copy link
Member Author

Stypox commented Jan 13, 2020 •
edited
Loading

Btw. I try to open milestones for further releases to help us focusing on a small number of PRs to be reviewed to speed up release cycles.

Yeah, it helped recently, thank you :-)

@cool-student done

@Stypox
Copy link
Member Author

Stypox commented Jan 14, 2020

Done, thank you :-D

@Stypox Stypox closed this as completed Jan 14, 2020
@TobiGr
Copy link
Contributor

TobiGr commented Jan 17, 2020

Thank you :)

@fightthepower
Copy link

not a dev, can I also request #2256 for Under the hood enhancements.

@Stypox
Copy link
Member Author

Stypox commented Jan 19, 2020

@fightthepower that's not really under the hood ;-)
I added it to missing service functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stypox Stypox

Labels
meta Related to the project but not strictly to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TobiGr @Stypox @cool-student @fightthepower @B0pol