Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag editing when downloading audio #183

Closed
fugounashi opened this issue Feb 15, 2016 · 23 comments
Closed

Tag editing when downloading audio #183

fugounashi opened this issue Feb 15, 2016 · 23 comments
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app

Comments

@fugounashi
Copy link

I guess YouTube doesn't provide structured artist/album/track fields so it'd be nice if there was a simple tag editor to set that info when downloading.

@theScrabi
Copy link
Member

I'm not going to implement something like this. But if you find a java lib that could do so, we could speak about this feature.

@monnier
Copy link

monnier commented Feb 20, 2016

FWIW, this is my main "wishlist item" for NewPipe, indeed.

@ghost
Copy link

ghost commented Feb 20, 2016 via email

@theScrabi
Copy link
Member

@wb9688 all right thanks. The only problem so far is, that I'd neet to implement it. But you might understand, that there are million other things which come first. So it also won't happen the next time, unless some of you guys help me :)

@theScrabi theScrabi added the feature request Issue is related to a feature in the app label Feb 21, 2016
@fugounashi
Copy link
Author

It seems the /Music structure is only /Music/album/track, so to get artist as well tags are needed.

As for libraries, I came across this: http://stackoverflow.com/questions/9707572/how-to-get-and-set-change-id3-tag-metadata-of-audio-files

can anyone recommend a tagging app as a workaround?

thanks!

@theScrabi
Copy link
Member

I think that would be something that should come first. A taging app on f-droid :P

@hydroid7
Copy link
Contributor

It is a have to to use _ characters for filenames? Or can we replace _ with " "?

Or it would be an opinion to ask for a filename before downloading it?

@Wiredframe
Copy link
Contributor

I'd also like to ask you to add at least SUPPORT for the M4a files to be tagged by another app. Right now it's not working because "This M4a file doesn't support ID3 tagging at all".

I hope it's possible because right now it's awful to convert m4a to mp3 just to tag them. ^^

As always, THANKS in advance!

@aFoxWhoIsNice
Copy link

Please add this feature. It would be fantastic.

@ghost
Copy link

ghost commented Feb 18, 2018 via email

@Wiredframe
Copy link
Contributor

The problem is that many apps say that it's not a valid m4a file, I guess the header is missing or something. But I found an app that can tag even those files, it's called AutomaTag.

@ghost
Copy link

ghost commented Feb 22, 2018

@Wiredframe: I don't know, but we're just downloading it straight from YouTube.

@Wiredframe
Copy link
Contributor

Thanks again. I guess this issue should be closed since there's nothing to do here ^^

@theScrabi
Copy link
Member

Oh well keep it open, you never know.

@ghost
Copy link

ghost commented Feb 22, 2018 via email

@albjeremias
Copy link

there could be a simplex regex to get most of the tags automatically... and show like advanced so user could edit the regex? or edit the automatic tag... also https://en.m.wikipedia.org/wiki/MusicBrainz could be used later...

@SkyzohKey
Copy link

SkyzohKey commented Jul 14, 2018

What about using the spotify API to get tags ? We can add this to the scrapper so that it is able to return tags for a YT video and apply them once download is finished I guess.

#see https://github.com/EnricoBilla/MusicTag/blob/master/musictag.py

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@SkyzohKey
Copy link

Don't close this, bot. 😉

@Stypox
Copy link
Member

Stypox commented Jun 23, 2019

Another way to get song name and author is this.
From the readme:

Imagine a playlist (id 1234567890abcdefghijklmnopqrstuvwx) whose second video (id 0a1b2c3d4e5) is titled ArtistName feat. Ft1 | SongName [Rel release](Remixer ft. Ft2 remix). [...] the song's ID3 metadata would be:

artist: "Remixer (original by ArtistName)"
title: "SongName (remix)"
tracknumber: "1"
album: "1234567890abcdefghijklmnopqrstuvwx"

"tracknumber" is 1 because the video is the second one of the playlist

@Stypox Stypox added the downloader Issue is related to the downloader label Jul 18, 2019
@Wilker-uwu
Copy link

i think it would be very useful for SoundCloud, where the album image and year of publishing should also be taken into consideration.

in addition to that (but a topic for another issue) is that i think that SoundCloud media should have something showing if the song is originally a free to download, a paid one, or if there was no link at all in the site, and the application should give the option to block or redirect(with a note in the download button text) downloads of songs that are paid.

@MakoriSM
Copy link

MakoriSM commented Feb 8, 2020

The ability to write your own artist and song name is definitely my most desired feature.
It would also be great if we could use the youtube thumbnail as album art

Newpipe looks like the best alternative to the now defunct Peggo but I hate having my music library filled with songs titled like: "verylongsongname (lyrics) - artist" with the artist set to: "unknown artist"

@opusforlife2
Copy link
Collaborator

I guess YouTube doesn't provide structured artist/album/track fields so it'd be nice if there was a simple tag editor to set that info when downloading.

It does (youtube-dl is capable of parsing it and adding it to the download), so I'm closing this in favour of #4341.

Atemu pushed a commit to Atemu/NewPipe that referenced this issue Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests