Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash upon refreshing feed quickly after Marking Videos as Watched from feed #11897

Closed
6 tasks done
jpggithub opened this issue Jan 11, 2025 · 5 comments
Closed
6 tasks done
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion

Comments

@jpggithub
Copy link

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.4

Steps to reproduce the bug

I just marked two YT video as seen then refreshed the list of the videos by dragging towards the bottom of my screen. Then newpipe crashed.

Usually I observed the same behavior when I launch newpipe for the first time since a few hours. For instance if the app crashed as described above, then I relaunched it and marks some other videos as seen and refrsh the list by dragging, the app does not crash anymore. Strange...

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: FR
  • Content Language: fr-FR
  • App Language: fr_FR
  • Service: none
  • Version: 0.27.4
  • OS: Linux Android 11 - 30
Crash log

java.lang.IllegalArgumentException: Cannot coerce value to an empty range: maximum 5 is less than minimum 6.
	at kotlin.ranges.RangesKt___RangesKt.coerceIn(_Ranges.kt:1413)
	at org.schabi.newpipe.local.feed.FeedFragment.highlightNewItemsAfter(FeedFragment.kt:591)
	at org.schabi.newpipe.local.feed.FeedFragment.handleLoadedState$lambda$12(FeedFragment.kt:408)
	at org.schabi.newpipe.local.feed.FeedFragment.$r8$lambda$J9x8R5DOxWmSMuC6e0IqaTQjYqY(FeedFragment.kt:0)
	at org.schabi.newpipe.local.feed.FeedFragment$$ExternalSyntheticLambda0.onUpdateComplete(R8$$SyntheticClass:0)
	at com.xwray.groupie.DiffTask.onPostExecute(DiffTask.java:61)
	at com.xwray.groupie.DiffTask.onPostExecute(DiffTask.java:18)
	at android.os.AsyncTask.finish(AsyncTask.java:771)
	at android.os.AsyncTask.access$900(AsyncTask.java:199)
	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:788)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7664)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)


Expected behavior

The app does not crash.

Actual behavior

The app crash.

Screenshots/Screen recordings

No response

Logs

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: FR
  • Content Language: fr-FR
  • App Language: fr_FR
  • Service: none
  • Version: 0.27.4
  • OS: Linux Android 11 - 30
Crash log

java.lang.IllegalArgumentException: Cannot coerce value to an empty range: maximum 5 is less than minimum 6.
	at kotlin.ranges.RangesKt___RangesKt.coerceIn(_Ranges.kt:1413)
	at org.schabi.newpipe.local.feed.FeedFragment.highlightNewItemsAfter(FeedFragment.kt:591)
	at org.schabi.newpipe.local.feed.FeedFragment.handleLoadedState$lambda$12(FeedFragment.kt:408)
	at org.schabi.newpipe.local.feed.FeedFragment.$r8$lambda$J9x8R5DOxWmSMuC6e0IqaTQjYqY(FeedFragment.kt:0)
	at org.schabi.newpipe.local.feed.FeedFragment$$ExternalSyntheticLambda0.onUpdateComplete(R8$$SyntheticClass:0)
	at com.xwray.groupie.DiffTask.onPostExecute(DiffTask.java:61)
	at com.xwray.groupie.DiffTask.onPostExecute(DiffTask.java:18)
	at android.os.AsyncTask.finish(AsyncTask.java:771)
	at android.os.AsyncTask.access$900(AsyncTask.java:199)
	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:788)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7664)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)


Affected Android/Custom ROM version

liemneageos 18.1

Affected device model

lenovo p2

Additional information

No response

@jpggithub jpggithub added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jan 11, 2025
@ShareASmile
Copy link
Collaborator

Is your earlier issue reoccurring #10847 ?

What about doing it again I mean Data export, Clear App Data, then Reimport as you tried here

@ShareASmile ShareASmile added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 12, 2025
@ShareASmile ShareASmile changed the title Mark videos as seen, refresh then Newpipe crash Crash upon refreshing feed quickly after Marking Videos as Watched from feed Jan 12, 2025
@jpggithub
Copy link
Author

jpggithub commented Jan 12, 2025

The Data export, Clear App data (delete then reinstall NewPipe) then reimport did not work.

Finally, I Data export, Clear App data, delete then reinstall NewPipe, then configure manually NewPipe with my preferred channels. The bug seems to be disappeared.

EDIT: Now I have to mark as seen several tens of videos already seen 😅

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 12, 2025
@ShareASmile ShareASmile added question Not really an issue, but more of a question about how something works feed Issue is related to the feed and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jan 12, 2025
@jpggithub
Copy link
Author

I reopen this bug as the crash problem still occurs in the same conditions.

Difference: I don't have anymore the usual log information that appears after the crash and that propose to communicate the bug by mail or github.

@jpggithub
Copy link
Author

I precise my previous message: when NewPipe crah for the same reason explained above, I then see only a notification that newpipe is updating something. The notification tells nothing about what is updated.

@ShareASmile
Copy link
Collaborator

Will be tracked in #10939

@ShareASmile ShareASmile added duplicate Issue or discussion is a duplicate of an existing issue or discussion and removed question Not really an issue, but more of a question about how something works feed Issue is related to the feed labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion
Projects
None yet
Development

No branches or pull requests

2 participants