-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve stack traces visualization in Sentry #2
Comments
If sentry provides support for this kind of stacking etc., please feel free to implement it in NewPipe as well as here. I basically took what I got years ago, and haven't touched the code since. The whole crash reporting isn't really used as much by the developers, probably because it's not as useful as it could be, so any improvements are welcome. |
To fix the issue with the custom stack trace parsing in Sentry not displaying wrapped exceptions and causing issues with identification of causes, the following process could be taken:
|
For example, wrapped exceptions, very common in Java, are not displayed at the moment and all the traces are just glued together with not indentation. It makes identifying the causes and other things a bit more difficult/impossible since the message from the cause is not displayed.
A very straightforward example of this issue would be this event: issues/4156/events/62029, which the cause would very likely be a exception from the
IOException
family.In fact, I bet a lot of the issues that are in Sentry right now are of this kind, a network issue that abruptly left the extractor in a bad state (which should be detected and handled correctly to avoid a full on app crash).
I think it's mainly caused by the way the custom stack trace parsing works, maybe this should be done on the client side, which then would send the information in a sane format and avoid regex in the first place?
Don't know much about Sentry, but would be willing to fix some time in the future if nobody takes care of it.
The text was updated successfully, but these errors were encountered: