Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#ifdef guards for enabling/disabling extensions #112

Open
LouisHLAV opened this issue May 20, 2022 · 1 comment
Open

#ifdef guards for enabling/disabling extensions #112

LouisHLAV opened this issue May 20, 2022 · 1 comment

Comments

@LouisHLAV
Copy link

Hi!

I'd love to use this library at work, but unfortunately we'd have to disable the usability extensions for future compatibility with the standard.
The noext branch seems a bit behind master, so I'm wondering if it'd be okay to add the option to enable/disable those extensions at compile-time.

If that seems like a good idea, I'd be happy to submit a PR 😃

Cheers, and thank you for the amazing lib!

LouisHLAV added a commit to LouisHLAV/expected that referenced this issue Aug 15, 2022
@asmaloney
Copy link

This would be convenient.

Use-case: if I include expected in the API of my library and want to switch it out later (if it is accepted as standard), I don't want to break my user's code if they have used these extensions...

(Alternatively, providing a parallel release which doesn't include them at all would be even better!)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants