router.subscribe pathChanged is true even when only query parameters change

[merthanmerter]

I noticed the pathChanged flag behaves in a way that might be counterintuitive. pathChanged is set to true even when only query parameters in the URL change, while the actual path remains the same.

subscribe("onBeforeLoad", ({ pathChanged }) => {
  console.log(pathChanged); // true
  set(pathChanged);
});

My approach to my current use-case to fix this is as below but imho it would make more sense if it was the default behavior of pathChanged. What do you think?

  const previousPath = React.useRef<ParsedLocation>(state.location);

  React.useEffect(() => {
    const unsubscribeStart = subscribe("onBeforeLoad", ({ toLocation }) => {
      if (previousPath.current.pathname !== toLocation.pathname) {
        setTransition(true);
        previousPath.current = toLocation;
      } else {
        setTransition(false);
      }
    });

    const unsubscribeResolved = subscribe("onResolved", () => {
      setTransition(false);
    });

    return () => {
      unsubscribeStart();
      unsubscribeResolved();
    };
  }, [previousPath, subscribe]);

[schiller-manuel]

I have added this PR: #2649

[schiller-manuel]

released in https://github.com/TanStack/router/releases/tag/v1.77.5