Skip to content
This repository has been archived by the owner on Feb 2, 2020. It is now read-only.

Support for Sub-IDs #16

Open
mickare opened this issue Mar 6, 2016 · 4 comments
Open

Support for Sub-IDs #16

mickare opened this issue Mar 6, 2016 · 4 comments

Comments

@mickare
Copy link

mickare commented Mar 6, 2016

Please add a way to set the Sub-IDs of both materials.

Either:
/v <mat>[:subid] -> /v 5:1

or like in the old times both commands /vi and /vri.

Greetings,
mike

PS: You do a great job. It was at first a strange change, but voxel should be more powerful than before. Altough it is a bit too complex / complicated (it takes longer than before) with those setter method (/vs <key> = <value>).

@gabizou
Copy link
Member

gabizou commented Mar 7, 2016

I'd like to point out that if anything, Gunsmith should be supporting block states and not "sub id's" which are almost completely phased out in Minecraft.

@mickare
Copy link
Author

mickare commented Mar 7, 2016

Naming it "BlockState", "MaterialState", "Sub-Id" or "asdf-ID" is not relevant. It's still the same.
Important is that you can set it somehow. ;)

I used voxel a lot in the old days and I think continuity of basics commands is a part of a great plugin.

Side-node/-question:
gabizou mentioned that it "almost completely phased out" in Minecraft, so...
Did the internal sub-id storing of minecraft change a lot in 1.9? I mean: How does it store the orientation of stairs, "sub-id"'s etc.? And how does it send to the client?
Technically it would be illogical that it would not be a simple integer (=sub-id). So I just assume it did not change that much. Then why naming it "BlockState" when it's still the same?

@Deamon5550
Copy link
Member

it is phased in all places but the chunk serialization in MC1.9 and for MC1.10 it will be completely removed. So adding support for a byte data value is not feasible for the future.

And I do agree with you on the complexity.

@mickare
Copy link
Author

mickare commented Mar 7, 2016

@Deamon5550 -> I splitted it into the issue #18.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants