Incendiary grenades explode without fire #1427
Comments
TimGoll
added a commit
that referenced
this issue
Jun 2, 2024
Fixes #1427 This pullrequests fixes the issue with incediaries not spawning fire particles (or spawning them in the next room if there is any) when exploding close to a wall. The relevant change for this fix is in the base grenade file:  This is not a TTT2 issue, it also [exists in vanilla TTT](https://github.com/Facepunch/garrysmod/blob/master/garrysmod/gamemodes/terrortown/entities/entities/ttt_basegrenade_proj.lua#L54). The issue exists because the trace, that should detect the ground, does not ignore the grenade itself and returns therefore a kind of random HitNormal. Since the grenade is then moved along the normal prior to explosion, this often resulted in the grenade being behing a wall and therefore not spawning any particles. Adding `self` to the filter would fix this issue as well, but after some quick thought I decided that `MASK_SOLID_BRUSHONLY` would be a fitting mask setting here. [[docs]](https://wiki.facepunch.com/gmod/Enums/MASK). This issue probably existed with ALL GRENADES that inherited from the weapon base. I wonder why nobody besides me ever reported this. Probably because you do not notice it during normal chaotic gameplay. Besides this change I also renamed some variables to be more in-line with our style, while also moving the fire grenade decal creation to the server. That way the decal spawns together with the explosion and not a few moments before. It looks cleaner that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This seems to be an issue in v0.12.x and v0.13.x. Maybe even earlier. At least from what I heard, it is to confirm if this issue existed before #1318.
When fire grenades explode next to a wall, they always spawn their fire particles behind the wall. This is confusing when there is a room next to it, but outright buggy, if there is nothing behind it because it makes the particles spawn really far out triggering the crazy physics tool that removes them completely.
The text was updated successfully, but these errors were encountered: