-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accounts request form: auto-unify country names #13104
Comments
I would like to contribute with the first alternative, it would be useful to have the common variations of the countries |
@damithc I think we can implement a search bar for Country/Region that allows the user to input a value and choose a match from a drop-down menu. If the input doesn't match with any item, then we can simply store the user input? If you think it's a good idea, I can work on it. |
@Shihuihuang1103 Thanks for your interest in this issue. I'm curious as to which list of countries do you propose to use? |
@damithc I found these two sources for list of countries and regions:
Please let me know if you think either of the above lists would be a good reference for this feature, or if you have another list in mind. |
@damithc @Shihuihuang1103 Hi, I was doing some research related to this issue, and I think that the ISO 3166 standard would be a good reference point for implementing this feature, as it is a universally accepted standard for country identification, and are easily integrated into the existing codebase with libraries such as iso-3166-1-alpha-2 and iso-3166-1. |
@itstrueitstrueitsrealitsreal Sorry, I missed this earlier. Yes, this seems like a good way to go, provided users will still have the option to type their own as well. |
* Added unified countries for InstructorRequestForm * Added tests for InstructorRequestForm for unified countries * Fixed lint errors for InstructorRequestForm * Added countries and moved countrymapping * Tests Fixed --------- Co-authored-by: Francisco Savala <[email protected]> Co-authored-by: Wei Qing <[email protected]> Co-authored-by: Ching Ming Yuan <[email protected]> Co-authored-by: domoberzin <[email protected]>
Hey , I am taking a class where I am supposed to contribute to an open source project . Is there a chance me and my team can try to solve this problem by attempting to create a drop down menu , the way someone mentioned it before ? |
Current:
United States
,USA
,US
, etc.USA
for the above example.Suggested:
USA
:U.S.A
,United States
,America
, ...UK
: ...UAE
: ...Germany
:Deutschland
Netherlands
: ...Belgium
:België
Brazil
:Brasil
Spain
:España
Mexico
:México
Italy
:Italia
The text was updated successfully, but these errors were encountered: