You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, there's a mismatch in behavior of the methods during the migration.
FeedbackSession only takes into account endTime, but the original method takes into account graceTime, deadlineExtensions and endTime.
Impact of bug
During the migration, due to similarity in names, some migrated actions are utilizing the wrong method.
Suggested change
As the FeedbackSessionAttributes did not need a separate isXXXGivenExtendedDeadline set of methods, a suggestion is to rename them inFeedbackSession and make the method signatures match the set of methods in FeedbackSessionAttributes.
Implement additional unit tests if need be.
The text was updated successfully, but these errors were encountered:
FergusMok
changed the title
Mismatch between FeedbackSession and FeedbackSessionAttributes isClosed, isOpened, isInGracePeriod
Resolve mismatch between FeedbackSession and FeedbackSessionAttributes isClosed, isOpened, isInGracePeriod
Feb 19, 2024
Currently, there's a mismatch in behavior of the methods during the migration.
FeedbackSession only takes into account
endTime
, but the original method takes into accountgraceTime
,deadlineExtensions
andendTime
.teammates/src/main/java/teammates/storage/sqlentity/FeedbackSession.java
Lines 454 to 477 in d6c67fc
teammates/src/main/java/teammates/common/datatransfer/attributes/FeedbackSessionAttributes.java
Lines 318 to 344 in d6c67fc
The actual behavior should instead use these methods:
teammates/src/main/java/teammates/storage/sqlentity/FeedbackSession.java
Lines 486 to 511 in d6c67fc
Impact of bug
During the migration, due to similarity in names, some migrated actions are utilizing the wrong method.
Suggested change
FeedbackSessionAttributes
did not need a separateisXXXGivenExtendedDeadline
set of methods, a suggestion is to rename them inFeedbackSession
and make the method signatures match the set of methods inFeedbackSessionAttributes
.The text was updated successfully, but these errors were encountered: