Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create about page component - Vanilla.js #233

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Create about page component - Vanilla.js #233

merged 3 commits into from
Oct 10, 2024

Conversation

29deepanshutyagi
Copy link
Contributor

@29deepanshutyagi 29deepanshutyagi commented Oct 9, 2024 •
edited by blackgirlbytes
Loading

This PR introduces the About page component for the Decentralized Web App (DWA) starter, implemented in Vanilla.js. The new component mirrors the content and structure of the existing React implementation, providing essential information about the DWA starter and its relevance.

Changes:

Created About component in components.js.
Added HTML structure:
    Main title (h1): "DWA Starter Vanilla"
    Paragraph: "Decentralized Web App: it's a Web5 Progressive Web App."
    Subtitle (h2): "Why PWA?"
    Paragraph: "It's a perfect match with Web5 DWNs since a PWA can work offline and DWN has synced local storage."
Ensured proper spacing and styling using Tailwind CSS for responsive design.




issue #90

Resolves #90

blackgirlbytes
blackgirlbytes requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Looks like the test is failing though . Let's get it to pass. Take a look here -- https://github.com/TBD54566975/tbd-examples/actions/runs/11247125645/job/31270080608?pr=233

@29deepanshutyagi
Copy link
Contributor Author

kindly review now

blackgirlbytes
blackgirlbytes approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution!

@blackgirlbytes blackgirlbytes merged commit ea5d15a into TBD54566975:main Oct 10, 2024
21 checks passed
@blackgirlbytes
Copy link
Contributor

blackgirlbytes commented Oct 10, 2024 •
edited
Loading

hi @29deepanshutyagi , it's really important to keep the PR template that's there, so you can automatically get added to the leaderboard especially the part where we have resolves # issue number or closes # issue number. Please don't change it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackgirlbytes blackgirlbytes blackgirlbytes approved these changes

@finn-block finn-block Awaiting requested review from finn-block

@angiejones angiejones Awaiting requested review from angiejones

@acekyd acekyd Awaiting requested review from acekyd

@EbonyLouis EbonyLouis Awaiting requested review from EbonyLouis

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create about page component - Vanilla.js
3 participants
@29deepanshutyagi @blackgirlbytes @taniashiba