New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ion.PatchesToDIDDocument has unused param #438

Open

andresuribe87 opened this issue Aug 2, 2023 · 0 comments

Contributor

andresuribe87 commented Aug 2, 2023

The first param is not used on the function

ssi-sdk/did/ion/did.go

Line 112 in 8db407f

    
           func PatchesToDIDDocument(shortFormDID, longFormDID string, patches []Patch) (*did.Document, error) {

We should remove it. Additionally, it should be made clear that it can be long/short form DIDs, as it should be up to the caller to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment