Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test suite #188

Open
decentralgabe opened this issue Apr 16, 2024 · 2 comments
Open

Add a test suite #188

decentralgabe opened this issue Apr 16, 2024 · 2 comments
Assignees
Labels
testing related to new or existing tests

Comments

@decentralgabe
Copy link
Member

Provide a way for implementers to prove conformance for different feature sets

@decentralgabe decentralgabe added the testing related to new or existing tests label Apr 16, 2024
@thehenrytsai
Copy link
Member

In terms of proving conformance/interoperability across different language implementations, today we have test vectors that allows us to go as far as validating each individual DNS record is in the correct format, but those checks does not guarantee the "bundle" (encodedDNS packet) that gets uploaded to the DHT is in the valid/expected format.

Provided the BEP44 message has deterministic signature AND different DNS packet encode libraries ALWAYS produces the same bytes given the same set of records even in DIFFERENT orders (these are big assumptions), it would be the most ideal for us to have test vector as close to the final output as possible: ie. either the BEP44 message itself, or the encoded DWN packet before the signature wrapping + test vector for BEP44 support.

@decentralgabe decentralgabe self-assigned this May 23, 2024
@decentralgabe
Copy link
Member Author

++ to supporting intermediary representations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing related to new or existing tests
Projects
None yet
Development

No branches or pull requests

2 participants