Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to wait for component to mount before scrolling element to view #487

Merged
merged 2 commits into from May 19, 2023

Conversation

kirahsapong
Copy link
Contributor

This PR addresses Issue #396 to fix anchor links not scrolling into view when navigated to

@netlify
Copy link

netlify bot commented May 19, 2023

Deploy Preview for tbd-website-developer ready!

Name Link
🔨 Latest commit 8c38da2
🔍 Latest deploy log https://app.netlify.com/sites/tbd-website-developer/deploys/64671811aa8dd30008a3fb11
😎 Deploy Preview https://deploy-preview-487--tbd-website-developer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@dayhaysoos dayhaysoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Ship it! 🫡🫡🫡

@kirahsapong kirahsapong merged commit e27be05 into main May 19, 2023
5 checks passed
@kirahsapong kirahsapong deleted the issue-396/fix-anchor-link-behaviour branch May 19, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants