Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tag <<variation>> on <<part def>> in PlantUML graphical representation #86

Open
westboros opened this issue Mar 30, 2024 · 2 comments

Comments

@westboros
Copy link

westboros commented Mar 30, 2024

Installed 2024-02 release and noticed that the <<variation>> tag is missing on <<part def>> elements. However, the <<variation>> tag is visible on <<part>> elements.

From the SysMLv2 spec, it seems the <<variation>> should appear on <<part def>> elements.

From 2a-OMG_Systems_Modeling_Languge.pdf Table 4. Definition and Usage - Representative Notation:

SysMLv2VariationPartDef

From my local eclipse project:

SysMLv2VarationTag

@westboros
Copy link
Author

westboros commented Mar 30, 2024

Perhaps this bit of code in SysML2PlantUMLText.java in org.omg.sysml.plantuml is causing the behavior (line 260):

private static void appendVariation(StringBuilder sb, Type typ) {
    if (!(typ instanceof Usage)) return;
    Usage u = (Usage) typ;
    if (u.isVariation()) {
        sb.append(" <<variation>>\\n");
    }
}

Not sure why there is a need to exit the appendVariation() method if typ is not an instance of a Usage.

@himi
Copy link
Member

himi commented Mar 31, 2024

I forgot the case that typ is of Definition. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants