Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also keep summary MACAW results in a text file #878

Open
edkerk opened this issue Sep 30, 2024 · 0 comments
Open

also keep summary MACAW results in a text file #878

edkerk opened this issue Sep 30, 2024 · 0 comments
Assignees

Comments

@edkerk
Copy link
Member

edkerk commented Sep 30, 2024

Current behavior:

MACAW tests are run as part of each PR, while summary results are posted as a comment (example), and more detailed results are committed in the macawResults folder. In the cited example (from PR #829), it is not that obvious that 482 more reactions were found in the category "reversible reactions that can only carry steady-state fluxes in a single direction due to dead-ends." when compared to the previous PR #840.

Expected feature/value/output:

For easier comparison of MACAW results with previous results, it would be useful to have the summary results also written in macawResults/README.md, so that the diff of the new commit clearly highlights the changes.

@edkerk edkerk self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant