Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid migrations to be autoloaded #654

Open
vasilvestre opened this issue Jan 10, 2022 · 3 comments
Open

Avoid migrations to be autoloaded #654

vasilvestre opened this issue Jan 10, 2022 · 3 comments

Comments

@vasilvestre
Copy link
Contributor

vasilvestre commented Jan 10, 2022 •
edited

Doctrine migration package specifies that migrations should NOT be autoloaded, thus the namespace is arbitrary and should be different from App\Migrations, which is the case in this distribution.

https://github.com/Sylius/Sylius/blob/master/UPGRADE-1.8.md#migrations
@Ferror
Copy link
Contributor

Ferror commented May 11, 2022

@vasilvestre Nice one!

Would you like to open PR with relatable improvement?

@vasilvestre
Copy link
Contributor Author

@vasilvestre Nice one!

Would you like to open PR with relatable improvement?

Sure it's not a big deal :)

@vasilvestre vasilvestre mentioned this issue Jul 15, 2022
Closed
@vasilvestre
Copy link
Contributor Author

As stated here, I use "DoctrineMigrations" as a namespace for files in %kernel.project_dir%/migrations

PR here : #797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid migrations to be autoloaded vasilvestre/Sylius-Standard
2 participants
@vasilvestre @Ferror