Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please explain motivation in the README #1

Open
eschen42 opened this issue Jan 4, 2022 · 0 comments
Open

Please explain motivation in the README #1

eschen42 opened this issue Jan 4, 2022 · 0 comments

Comments

@eschen42
Copy link

eschen42 commented Jan 4, 2022

@Superchen17
This isn't really a bug, but rather a request for information.

I am curious why you did not use the pip-installable 'pyahocorasick` rather than writing your own. Please don't take this to be a criticism - sometimes there are particular reasons to work with a fresh implementation, e.g., other implementations may not be designed to be used in the way that you have in mind, etc.. Furthermore, I see the benefit in doing an implementation to understand the algorithm better. I also have tried to do implementations 'purely' in one language rather than relying upon libraries written in another language. And, indeed, I post to public GitHub repos things that I am coding for whatever reason without worrying whether it might somehow be useful to anyone else.

So, if you care to share what your motivation is, I'd like to know. What might be particularly informative is the execution speed of your implementation compared to pyahocorasick.

Thank you in advance for taking this inquiry in the spirit intended, and happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant