Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InitScript bug when teleporting #698

Open
Narre opened this issue Apr 29, 2017 · 2 comments · May be fixed by #3011
Open

InitScript bug when teleporting #698

Narre opened this issue Apr 29, 2017 · 2 comments · May be fixed by #3011
Labels
hacktoberfest help wanted involves:scripting type:bug
Milestone
Future

Comments

@Narre
Copy link
Contributor

Narre commented Apr 29, 2017

SuperTux version: current git version (28.04.2017)
System information: Ubuntu 17.04 64-bit

Expected behaviour: InitScript should be either stopped and triggered again when Tux is teleported, or it should be neither stopped nor triggered again.

Actual behaviour: InitScript is triggered again when Tux is teleported, but it isn't stopped when it's already running.

Steps to reproduce actual behaviour: Try it with a script that runs for a long time or contains an infinite loop.

Video (might help if you don't know what I mean): https://www.youtube.com/watch?v=ZEkpM3VxFWU

Note: I haven't tried this with multiple sectors.
Note: I have included swimming before compiling, so, even though it is very unlikely, this might be an issue that only occurs with swimming included.
@maxteufel maxteufel added involves:scripting status:needs-discussion Team member and developers need to discuss of decisions type:bug labels Apr 30, 2017
@maxteufel maxteufel added this to the 0.6.0 milestone Apr 30, 2017
@maxteufel
Copy link
Member

This mostly needs discussion, but I'm in favor of not stopping the script and not triggering it again, at least until we have a recommendation on long-running scripts. @tobbi, what do you think?

@tobbi
Copy link
Member

tobbi commented May 3, 2017

I agree with you, @maxteufel. Restarting the script doesn't make sense, especially when the script is important for tracking level progress.

@christ2go christ2go self-assigned this Jun 6, 2017
@christ2go christ2go removed their assignment Aug 6, 2017
@maxteufel maxteufel added hacktoberfest and removed status:needs-discussion Team member and developers need to discuss of decisions labels Oct 1, 2017
@tobbi tobbi modified the milestones: 0.6.0, 0.5.1, Future Dec 16, 2018
tobbi added a commit that referenced this issue Jul 11, 2024
@tobbi
Run init-script only once after a sector has loaded
6fdf49f 
Fixes #698
@tobbi tobbi linked a pull request Jul 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted involves:scripting type:bug
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Run init-script only once after a sector has loaded SuperTux/supertux
4 participants
@tobbi @maxteufel @christ2go @Narre