Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PhysFS functions into PhysfsUtil and rely on PhysFSUtil more #2880

Open
tobbi opened this issue Apr 2, 2024 · 1 comment
Open

Move PhysFS functions into PhysfsUtil and rely on PhysFSUtil more #2880

tobbi opened this issue Apr 2, 2024 · 1 comment
Labels
category:code status:needs-discussion Team member and developers need to discuss of decisions type:idea

Comments

@tobbi
Copy link
Member

tobbi commented Apr 2, 2024

We have a wild mix between using physfsutil for tasks and raw PHYSFS_-prefixed functions.

It would be great if all the relevant functions could be moved into physfsutil. That makes it much easier in case of API changes because we only need to update the relevant parts in the PhysfsUtil class.

As PhysFS is moving beyond 2.0 into 3.0 territory with API changes...well...

@tobbi tobbi changed the title Move PhysFS functions into PhysfsUtil Move PhysFS functions into PhysfsUtil and rely on PhysFSUtil more Apr 2, 2024
@mrkubax10 mrkubax10 added type:idea status:needs-discussion Team member and developers need to discuss of decisions category:code labels Apr 2, 2024
@Vankata453
Copy link
Member

Most times I've looked at parts of the code that perform PhysFS operations, I have thought the same... physfsutil should be more widely used as a wrapper throughout the source indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code status:needs-discussion Team member and developers need to discuss of decisions type:idea
Projects
None yet
Development

No branches or pull requests

3 participants