Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperTux 0.3.5a fails to parse repository file index-0_4_0.nfo #13

Open
Grumbel opened this issue Jan 9, 2016 · 6 comments
Open

SuperTux 0.3.5a fails to parse repository file index-0_4_0.nfo #13

Grumbel opened this issue Jan 9, 2016 · 6 comments

Comments

@Grumbel
Copy link
Member

Grumbel commented Jan 9, 2016

 [WARNING] /build/supertux-f3Xlnc/supertux-0.3.5a/src/addon/downloader.cpp:354 Exception in Downloader: Problem when reading Add-on list: Problem when parsing addoninfo: not a valid Addon::Type: languagepack

SuperTux 0.3.5a is the version shipped with Ubuntu15.10

@brmbrmcar
Copy link

Why is it getting it from there instead of index-0_3_5.nfo?

@LMH0013
Copy link
Contributor

LMH0013 commented Jan 9, 2016

My guess is because after the 0.3.5 release, the index was changed to 0.4.0 in anticipation of the next release. Nobody caught and reversed it for 0.3.5a.

@tobbi
Copy link
Member

tobbi commented Jan 9, 2016

That's exactly what happened.

@maxteufel
Copy link
Member

That's what I was saying as well, as such this is an issue for the distro package managers, who should patch this in their releases. We can't magically change the 0.3.5a release anymore.

Grumbel added a commit to SuperTux/supertux that referenced this issue Jan 9, 2016
@Grumbel
Copy link
Member Author

Grumbel commented Jan 9, 2016

The distro maintainers can't do much, as they don't have a correct .nfo to point to. It would also be a waste of time to fix 0.3.5a when they could just update to 0.4.0 instead.

Possible solutions: Remove language packs from 0.4.0.nfo, put them in 0.4.1.nfo, update 0.4.1 to point to new .nfo, breaks language packs in 0.4.0 obviously, but fixes 0.3.5a.

Alternative solution: Forget about 0.3.5a, was a dev-snapshot anyway and just redirect users to 0.4.0

For the future:

  • make repository_url configurable by the user (currently hardcoded)
  • allow more then one repository url
  • add a 'news box' at the start of the game that we can use to display text to the user to inform them of new releases and such

@maxteufel
Copy link
Member

The distro maintainers can't do much, as they don't have a correct .nfo to point to.

I do think index-0_3_5.nfo should work with 0.3.5a.

Alternative solution: Forget about 0.3.5a, was a dev-snapshot anyway and just redirect users to 0.4.0

I like this idea, however, distros with a big userbase (Ubuntu, Fedora) packaged 0.3.5a anyway.

For the future:

  • make repository_url configurable by the user (currently hardcoded)
  • allow more then one repository url
  • add a 'news box' at the start of the game that we can use to display text to the user to inform them of new releases and such

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants