Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not considering some used in the comprehension body when checking the comprehension assignment #528

Open
nevumx opened this issue Jan 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nevumx
Copy link

nevumx commented Jan 2, 2024

idiomatic/use-some-for-output-vars and style/prefer-some-in-iteration are violated in this playground, even though they shouldn't be: https://play.openpolicyagent.org/p/SQNTZtJ0be

e.g.

build_obj(params) := result if {
	param_paths := {
		"principal": ["principal"],
		"action": ["action"],
		"entity": ["entity"],
	}
	param_objects := [build_object_path(param_paths[param_key], param_value) | some param_key, param_value in params]
	result := object.union_n(param_objects)
}
@anderseknert anderseknert added the bug Something isn't working label Feb 23, 2024
anderseknert added a commit that referenced this issue Feb 23, 2024
This fixes one of the errors reported in #528

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit that referenced this issue Feb 23, 2024
This fixes one of the errors reported in #528

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit that referenced this issue Feb 27, 2024
This fixes one of the errors reported in #528

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit that referenced this issue Mar 7, 2024
This fixes one of the errors reported in #528

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit that referenced this issue Mar 7, 2024
…579)

This fixes one of the errors reported in #528

Signed-off-by: Anders Eknert <[email protected]>
@anderseknert
Copy link
Member

First issue (prefer-some-in-iteration) fixed in #579. On to the next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: TODO
Development

No branches or pull requests

2 participants