Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this boostrap theme it's a really great work !
To make it even better I used few tools like Google Lighthouse to analyse this theme. I want a simple website yet with a fast loading time.
Results were far from perfect so before using it for myself I had to fix things and I wanted to share it so it can help others.
My results :
Here is the list of changes :
I followed this excellent article : https://blog.assistancy.be/blog/fontawesome-performance-host-locally
Original size of all.js : 1 774 kB
Stripped size :
brand.js : 8 Ko
solid.js : 9 Ko
fontawesome.min.js : 54 Ko
The main drawback for this 'ready-to-use' project : beginners trying to add new icons need to know how to do it properly because it requires one more step. An explanation in the README file could do the job imho. Loading time is much faster without this 1,7Mo file and we use only 9 different icons in it.
My commits could be more clean so I hope this post will help you go through my work ;)
Have a nice day