-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make packs/virtualenv file copy more robust (use rsync
w/ fallback to cp
)
#245
Labels
Milestone
Comments
cognifloyd
changed the title
Make packs/virtualenv file copy more robust
Make packs/virtualenv file copy more robust (use Jan 28, 2023
rsync
w/ fallback to cp
)
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
For system packs, and for any images in
st2.packs.images
, we copy packs and virtualenvs into /opt/stackstorm.Before #199, the packs volumes were always
emptyDir
, so using/bin/cp -aR
was just fine.In #160 (comment), it was noted that the
st2packs
image does not haversync
so we have continued with/bin/cp
even though rsync could be a bit better.After #199, the underlying volume's filesystem might not support preserving ownership, timestamps or other attributes, as reported in #238. In #238, the NFS exports were setup with
root_squash
which prevented ownership preservation. Debugging that was quite annoying.So, it would be better to handle different filesystems more gracefully. If we can preserve ownership and file permissions, great. But we should only fail if the file contents do not get copied. We might also need to fail if executable files are not executable after copy.
rsync
is probably the best tool to do this -> We need to add it to thest2packs
image.But, we do not want to force everyone to rebuild their
st2packs
images, especially if they are not and do not intend to use the newst2.packs.volumes
feature. So, ifrsync
is not available, we need to fall back to usingcp
.See comments:
st2packs
st2packs
We should probably do this before prod/GA to have minimal impact on GA adopters.
rsync
tost2packs
image Install rsync in st2packs images st2packs-dockerfiles#26The text was updated successfully, but these errors were encountered: