Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pry string generation out of threads #31

Open
Square789 opened this issue Aug 29, 2021 · 0 comments
Open

Pry string generation out of threads #31

Square789 opened this issue Aug 29, 2021 · 0 comments
Assignees
@Square789
Labels
code cleanup Code-cleanliness internal issue low priority

Comments

@Square789
Copy link
Owner

Strings to display to the user should only be created by the dialogues/whatever receives and processes the thread signals
@Square789 Square789 added the code cleanup Code-cleanliness internal issue label Aug 29, 2021
@Square789 Square789 self-assigned this Aug 29, 2021
Square789 added a commit that referenced this issue Aug 30, 2021
@Square789
Some more progress
3682f00 
- Changed all remnants of IOError to OSError since apparently the former is just an alias
- Fixed IndexError on last_path out of range
- Fixed double reloadgui call on a call to directory selection
- Made beginnings to work towards #31
- Added some documentation to threads and their signals
-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Square789 Square789

Labels
code cleanup Code-cleanliness internal issue low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Square789