Docker Compose Edits for BloodHound CLI #997
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
name
label to the containers and uncomments the bloodhound.config.json volume mounting by default. These changes enable some of the functionality built into the upcoming BloodHound CLI.The most significant change here is using bloodhound.config.json by default. The CLI ensures the file is present, but someone could run into issues if they do not use the CLI. We have been discussing switching the getbhce link to pull down pre-built binaries so new users would download the CLI and run
./bloodhound-cli install
to get started. I am unaware of any decision or movement on that. For now, I think this change will need some consideration.Motivation and Context
The
name
labels allow human-identifiable names to be displayed alongside container information when BloodHound CLI'srunning
command is used. It also makes it easier for someone to pull logs from a container (e.g.,./bloodhound-cli logs postgres
).How Has This Been Tested?
I have been testing the changes with the
main
branch and the current version of BloodHound CLI with Stephen Hinck and others. The changes do not impact the containers.Screenshots (optional):
Example of the
name
labels in output:Types of changes
Checklist: