New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape templates #5

Open

darrenbelding opened this issue Jul 12, 2018 · 1 comment

Member

darrenbelding commented Jul 12, 2018

Templates currently use the /* @escapeNotVerified */ annotation. As of 2.2, these annotations should be removed and the correct escape strategy used

Expected outcome:

Module passes Magento's Xss Unsafe Output static test

Actual outcome:

Module fails Magento's Xss Unsafe Output static test

Contributor

diazwatson commented Jan 10, 2019

@darrenbelding could you submit a PR with the suggested changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment