Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressions are sometimes not applied correctly #5186

Open
georgii-borovinskikh-sonarsource opened this issue Jan 22, 2024 · 0 comments
Open
Labels

Comments

@georgii-borovinskikh-sonarsource
Copy link
Contributor

This happened on slvs-vs2019-pro-16-7 first in file
Taint_CSharp_NetCore_WebAppReact/Suppressions_CSharp.cs when I was testing 7.6.0.82886 release candidate

None of the suppressions were applied.

I tried to repro it on my machine and I could in vs22 with a local build.
After I debugged it I figured a few things out.

  • The file in AppData\Local\Temp\SLVS\Roslyn was generated correctly
  • I could not debug the roslyn diagnostic suppressor

After that I deleted the generated file and updated the binding. That shouldn't have changed anything, but the suppressions were now applied correctly. I tried doing the same on the VM, but it didn't help. I tried a few things (downgrade to 7.5 release, update binding, restart the VM), but the issue still persisted. When I confirmed that it's not a regression and it happens on 7.5, I continued with the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant