Plugin registers task while disabled

[xknat]

Is there an existing feature request for this?

• I have searched the existing feature requests

Describe your feature request

[CSneko]

I also meet the same problem,look like it's can't check update form github.
In this class:UpdateCheckerGitHub.checkForUpdate(),

            GitHubReleaseInfo releaseInfo = response.getBodyAs(GitHubReleaseInfo.class);

            Optional<GitHubAssetInfo> jarAsset = releaseInfo.getAssets().stream()
                    .filter(asset -> asset.getName().equals(JAR_ASSET_NAME))
                    .findFirst();

getAssets() retrun null

[CSneko]

I found a solution：
Clone source,then open net.skinsrestorer.shared.update.UpdateCheckerGitHub
set value of private static final String RELEASES_URL_LATEST,look like:

private static final String RELEASES_URL_LATEST = "https://w.csk.asia/other/latest.json";

Then building,It's OK.
tips:
It will affect update functionality!
You can replace https://w.csk.asia/other/latest.json to your website.

[AlexProgrammerDE]

This basically just changes the update endpoint. The proper fix needs to be found, not by using a third party API, which will not be up-to-date with the actual latest version in the long run.

[AlexProgrammerDE]

Using a third-party endpoint is gonna give the domain host the ability to install malicious jars onto your server just by modifying the jar download url.

[CSneko]

Using a third-party endpoint is gonna give the domain host the ability to install malicious jars onto your server just by modifying the jar download url.

Yes，You are right.What I did was just solve the error.What can be seen is that the country where his server is located may not be able to connect properly with github.
I don’t know if this error report has other effects.So I just get the json file form github api,then upload to my website.
https://w.csk.asia/ is my plugins' page.I upload somthing for my server because my server also can't connect to github.com.
The correct approach (in my opinion) is to build a simple website that can be accessed in his country/region to obtain the github api, (for example: Cloudflare Workers).But it's maybe difficult.