Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minecells 1.8.0 crash #1085

Open
oof100200 opened this issue May 13, 2024 · 5 comments · May be fixed by #1053
Open

minecells 1.8.0 crash #1085

oof100200 opened this issue May 13, 2024 · 5 comments · May be fixed by #1053
Assignees
Labels
compat A mod is found to be incompatible fixed in dev Fixed in dev. Awaiting a new release.

Comments

@oof100200
Copy link

Mod Name

Minecells

Mod Homepage

https://modrinth.com/mod/minecells/version/1.8.0

Minecraft version

1.20.1

Describe the bug

crash on startup

Steps to reproduce

doesn't crash with version 1.7.3, but with 1.8.0 it does.

Logs

https://gist.github.com/oof100200/a0bc60b478b1f0d6a6c3971154f3e2c3

Additional context

No response

@oof100200 oof100200 added the compat A mod is found to be incompatible label May 13, 2024
@mim1q
Copy link

mim1q commented May 13, 2024

Found the culprit - MixinExtras' @ModifyExpressionValue mixins seem to crash Connector, while they work just fine on Fabric.
Got two of those in Mine Cells: here and here. Disabling these Mixins and recompiling the mod allows the game to launch.

@oof100200
Copy link
Author

找到罪魁祸首 - MixinExtras 的@ModifyExpressionValuemixins 似乎使 Connector 崩溃,而它们在 Fabric 上工作得很好。 在 Mine Cells 中找到了其中的两个:这里这里。取消这些 Mixins 并重新编译 mod 即可启动游戏。

thanks.

@Willem07
Copy link

How do disable the mixing and recompile mod?

@mim1q
Copy link

mim1q commented May 26, 2024

How do disable the mixing and recompile mod?

You shouldn't try to do that, it'll break a few things in the mod. I was just saying that I definitely know these mixins are the problematic thing here.

@Quasarx64
Copy link

Can confirm I am having this same issue on the latest version of Minecells (1.8.2) With the same cause.

@Su5eD Su5eD self-assigned this May 30, 2024
Su5eD added a commit that referenced this issue May 30, 2024
@Su5eD Su5eD added the fixed in dev Fixed in dev. Awaiting a new release. label May 30, 2024
@Su5eD Su5eD linked a pull request May 30, 2024 that will close this issue
@kakashi1464 kakashi1464 mentioned this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat A mod is found to be incompatible fixed in dev Fixed in dev. Awaiting a new release.
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

5 participants