Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymbolicBlockMatrix memory leak #30

Open
jorisv opened this issue Dec 1, 2023 · 0 comments
Open

SymbolicBlockMatrix memory leak #30

jorisv opened this issue Dec 1, 2023 · 0 comments
Assignees
@jorisv
Labels
enhancement New feature or request

Comments

@jorisv
Copy link
Contributor

jorisv commented Dec 1, 2023 •
edited
Loading

SymbolicBlockMatrix store two raw pointers.

These pointers are not owner by SymbolicBlockMatrix and this create leaks in unit tests and benchmarks.

Two options :

  1. Make SymbolicBlockMatrix owner of these two pointers
  2. Create SymbolicBlockMatrixHandler that will own a SymbolicBlockMatrix and these two pointers

Since these two pointers are only used by SymbolicBlockMatrix I prefer option 1.
@jorisv jorisv added the enhancement New feature or request label Dec 1, 2023
@jorisv jorisv self-assigned this Dec 1, 2023
@jorisv jorisv changed the title SymbolicBlockMatrix leak memory SymbolicBlockMatrix memory leak Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisv jorisv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorisv