Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all 72 0D models from pfaller22 #96

Open
1 task done
mrp089 opened this issue Jan 23, 2024 · 0 comments
Open
1 task done

Add all 72 0D models from pfaller22 #96

mrp089 opened this issue Jan 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mrp089
Copy link
Member

mrp089 commented Jan 23, 2024

Problem

We currently have only three "real-world" examples from the VMR as (calibration) tests. It would be nice to test a whole variety of "real-world" models to make sure they still run (fast) when we make changes to the solver.

Solution

Add all 72 0D models from pfaller22. This would have the added benefit of providing new users with a variety of examples.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@mrp089 mrp089 added the enhancement New feature or request label Jan 23, 2024
@menon-karthik menon-karthik added good first issue Good for newcomers and removed good first issue Good for newcomers labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@menon-karthik @mrp089