Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify attribute names? #85

Open
mrp089 opened this issue Dec 8, 2023 · 1 comment
Open

Unify attribute names? #85

mrp089 opened this issue Dec 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mrp089
Copy link
Member

mrp089 commented Dec 8, 2023

While working on #83, I noticed that we have different names for the same attributes in different 0D blocks:

  • Name: vessel_name, bc_name, junction_name, name, no name
  • Type: zero_d_element_type, bc_type, junction_type, closed_loop_type, type, no type
  • Values: zero_d_element_values, bc_values, junction_values, values

We could unify this by requiring every block to have name, type, values, simplifying reading the input file. An exception is ClosedLoopHeartAndPulmonary, which doesn't have a name or type (but could have in the future?).

The changes to the SimVascular 0D model generation would be very simple and limited to this file. However, it would also mean that all current users need to change their input files. We could provide a Python script for the migration.

@menon-karthik, any thoughts on if this is worth doing (and if yes, how to do it)? Any other changes we should make in addition?

@mrp089 mrp089 added the enhancement New feature or request label Dec 8, 2023
@menon-karthik
Copy link
Member

I'm on board with this! I think we should retain the backward compatibility as long as it isn't difficult to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants