-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify attribute names? #85
Labels
enhancement
New feature or request
Comments
Merged
I'm on board with this! I think we should retain the backward compatibility as long as it isn't difficult to maintain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on #83, I noticed that we have different names for the same attributes in different 0D blocks:
vessel_name, bc_name, junction_name, name
, no namezero_d_element_type, bc_type, junction_type, closed_loop_type, type
, no typezero_d_element_values, bc_values, junction_values, values
We could unify this by requiring every block to have
name, type, values
, simplifying reading the input file. An exception isClosedLoopHeartAndPulmonary
, which doesn't have aname
ortype
(but could have in the future?).The changes to the SimVascular 0D model generation would be very simple and limited to this file. However, it would also mean that all current users need to change their input files. We could provide a Python script for the migration.
@menon-karthik, any thoughts on if this is worth doing (and if yes, how to do it)? Any other changes we should make in addition?
The text was updated successfully, but these errors were encountered: