-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input files generated from API use "internal_junction" instead of "NORMAL_JUNCTION" #106
Comments
Adding what we discussed yesterday: If that does not fix this, maybe this issue should be moved to SimVascular because it is related to the API creating the wrong input files, not the 0D solver itself. |
This should have been fixed. However, I'm not sure what our plans are with a new release. @natalia-rubio, can you build SimVascular from source and check if it works? The only way to avoid discrepancies between SimVacsular and svZeroDSolver (which are guaranteed to happen again) is to add continuous integration to SimVacsular via its Python API. |
Description
Input files generated from API have "internal_junction"s instead of "NORMAL_JUNCTION"s. "internal_junction" doesn't seem to be used anymore in the solver. The solver returns the following error when provided an input file with an "internal_junction":
RuntimeError: Invalid block type internal_junction
If one replaces all instances of "internal_junction" with "NORMAL_JUNCTION", the solver runs fine.
Reproduction
Generate an input file with this code, and attempt to run it with the 0D solver:
https://github.com/SimVascular/SimVascular-Tests/blob/master/new-api-tests/simulation/reduced-order-modeling/simulation.py
Expected behavior
Input files generated with this code should run in the 0D solver.
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: