Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface to code coverage and combine tests #103

Open
1 task done
menon-karthik opened this issue Feb 15, 2024 · 1 comment
Open
1 task done

Add interface to code coverage and combine tests #103

menon-karthik opened this issue Feb 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@menon-karthik
Copy link
Member

Problem

The current code coverage does not include the C++ interface and its tests. We should fix this.

We might also want to streamline the three interface tests into one test. Pro: It is cleaner. Con: The current tests serve as examples on how to use the interface for different situations. Combining the tests will make them less useful as examples.

Solution

According to @mrp089, the including the interface tests in the code coverage might just require adding the code from the main CMakeLists to the CMakeLists inside tests/test_interface/.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@menon-karthik menon-karthik added the enhancement New feature or request label Feb 15, 2024
@mrp089
Copy link
Member

mrp089 commented Feb 15, 2024

For reference: We include coverage for svFSI and svFSILS in separate CMakeLists.txt as well, controlled by the main one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants