Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct error handling in svpre when creating a BCT file #76

Open
ktbolt opened this issue Apr 20, 2020 · 1 comment
Open

Add correct error handling in svpre when creating a BCT file #76

ktbolt opened this issue Apr 20, 2020 · 1 comment
Assignees
Labels

Comments

@ktbolt
Copy link
Contributor

ktbolt commented Apr 20, 2020

A user is trying to performa a simulation of a coronary model. Selecting the Create Data Files for Simulation button and waiting a long time the Create data files has been created window is displayed with no errors. However, selecting the Show Details button on this window lists the following error message 260 times

ERROR:  Line does not intersect vtkPolyData!

Looking in the svpre source I see that this error message is written by a function doing something related to creating the BCT file (inlet velocity profile).

There are several functions called when when creating the BCT file and even though all of these functions return an error code (CV_OK or CV_ERROR) the returned error code is never checked.

I will add code to check for error conditions and add a message that could actually be useful to a user. An error condition needs to be propagated back to SV so it can notify the user that an error has occurred.

@ktbolt ktbolt added the bug label Apr 20, 2020
@ktbolt ktbolt self-assigned this Apr 20, 2020
@ellipsis14
Copy link

ellipsis14 commented Aug 12, 2020

Hi @ktbolt ,
Any update on this issue as I am getting the same message when I try to create data files for simulation. The error occurs after SV starts to write the restart files. I loaded the geometry files (.stl) from external CAD source package and the segmentation was not done with SV segmentation routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants